No Wayman <iarchivedmywholel...@gmail.com> writes: > In order to properly generate org-version.el, the current build in > mk/targets.mk requires a query of the repo's tags. Shallow clones > do not have tags and so org-version will be generated as "N/A". In > the attached patch, support for generating org-version.el from > shallow clones is added. It is done by querying the upstream > remote via git ls-remote and parsing the output. In this case, a > more well formed org-version string will be generated. However, it > will be missing the "commits since last tag" information. e.g. > > "release_9.6.1-n/a-gabc123"
As discussed, this is a reasonable addition. However, I am concerned about the following scenario: 1. Shallow clone is created 2. make autoloads is issues when system is disconnected from internet May it be properly handled? We can put N/A at the version tag as well in such case. What we should not have is "make autoloads" failing without internet. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
