it is all ok with me, but not everybody has personal test cases for sorting sequence, and soembvody might get bitten by a subtle change like this which pop up every once in a while. thus the conflated thing -> 2 names. the old one could be deprecated or so, i was thinking. i get your points though and didn't realize about the docstroing. i have no strong opinion on this; just wanted the idea of disambiguating out there. as long as 2 things are not conflated that's good.
On 3/24/23, Ihor Radchenko <yanta...@posteo.net> wrote: > Samuel Wales <samolog...@gmail.com> writes: > >> i find that when 2 things are being conflated, whether in software or >> in anything else, it is useful to change the name of both of them for >> maximum clarity, future git searches, etc. >> >> thus, perhaps i would suggest somthign like this slight tweak instead. >> >> priority-cookie-up >> priority-cookie-and-planning-urgency-up > > I do not like the idea of changing both the names. The current change > will ensure that existing uses of "priority-up"/"priority-down" sorting > strategies won't be affected too much. Forcing every Org user who > customized agenda sorting to change the variable values is not > acceptable. > > Note that the patch, despite changing the actual meaning of > priority-up/down, makes it more conforming with > `org-agenda-sorting-strategy' docstring. So, this change is, in fact, > safe. > >> if not too verbose. reasoning: urgency is occasionally considered >> orthogonal to priority in some philosophies, and some users have >> :urgent: tags. so this might eliminate slightly more confusion in >> principle. > > I am neutral wrt "urgency" term. We can use some other. > > I do not like the verbosity. Even something like > "priority-and-urgency-up/down" sounds awkward, IMHO. > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com
