Gavin Downard <gavin.down...@runbox.com> writes: > Ihor Radchenko <yanta...@posteo.net> writes: >> Do we have any tests covering this part of the code? > > Not that I know of. I can add a test case for this specific instance, > but I'm not sure if I should add more comprehensive tests in this patch. > What do you think?
I'd prefer to see tests for the aspects of org-table that are modified by the patch (if there are no tests available). org-table is an old, not very readable code. So, we should better ensure test coverage to avoid breakage. Eyeballing the code is not very reliable in this case. >> In Emacs 26, we will need (require 'subr-x), but otherwise it is not a >> problem to use `if-let'. > > Oh, I didn't realize that. Sorry about that. Nothing to sorry about. You do not even need to do anything. org-compat is already loaded by org-table and org-compat loads subr-x. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
