Mehmet Tekman <mtekma...@gmail.com> writes: >> Another meetup is on July 26. https://emacs-berlin.org/ >> Or we can arrange a jitsi call. > > Sure, I can be there tomorrow!
Ok. There are several talks planned at the beginning, and we may discuss your patch after those. >> The tests are indeed not passing on vanilla Org. I assume that you >> tested them with your other patch applied. > > I tested them on upstream/main... or so I thought, though I now > realise that I needed to delete the =~/.emacs.d/straight/build/org= > directory to trigger a rebuild of org-mode for the current branch I > was on. (Live and learn...) That should not normally be necessary. Not sure what happened in your setup. > Problem: My testing patch is indeed not working on vanilla Org, but it > contains tests that will (presumably) work with the new > merge-params patch. > > Question: What is the order of submission of patches? > > Do I submit a testing patch first which works strictly with > vanilla Org first, and then a new merge-params function, and > then yet another testing patch that is compliant with the > new merge-params function? > > Or do I submit the new merge-params function, and then my > testing patch on top? Either way is fine. The latter should be easier for you though. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
