On Wed, Aug 23 2023, Ihor Radchenko <yanta...@posteo.net> wrote:
> Leo Butler <leo.but...@umanitoba.ca> writes:
>
>> Does org-cite monitor contents or the timestamp?
>> I am using a symlink to the bib file.
>
> Timestamp.
>
> Does the attached patch fix the problem?
Thanks, Ihor.
To avoid an unneeded setq, I applied the patch:
(dolist (file (mapcar #'file-truename (org-cite-list-bibliography-files)))
This caused the bibtex file to be re-parsed when I changed it.
Best,
Leo
>
> From 39b503301fc7a3ea68733dfd9e4391e3f84efec8 Mon Sep 17 00:00:00 2001
> Message-ID:
> <39b503301fc7a3ea68733dfd9e4391e3f84efec8.1692781998.git.yanta...@posteo.net>
> From: Ihor Radchenko <yanta...@posteo.net>
> Date: Wed, 23 Aug 2023 12:12:13 +0300
> Subject: [PATCH] oc-basic: Fix detecting changes in symlinked bibliography
>
> * lisp/oc-basic.el (org-cite-basic--parse-bibliography): Use
> `file-truename' to follow symlinks first before checking bibliography
> file change times.
>
> Reported-by: Leo Butler <leo.but...@umanitoba.ca>
> Link: https://orgmode.org/list/877cpmkds1....@t14.reltub.ca
> ---
> lisp/oc-basic.el | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
> index 84d9492ea..c4468e5a8 100644
> --- a/lisp/oc-basic.el
> +++ b/lisp/oc-basic.el
> @@ -272,6 +272,9 @@ (defun org-cite-basic--parse-bibliography (&optional info)
> (plist-get info :cite-basic/bibliography)
> (let ((results nil))
> (dolist (file (org-cite-list-bibliography-files))
> + ;; Follow symlinks, to look into modification time of the
> + ;; actual file, not its symlink.
> + (setq file (file-truename file))
> (when (file-readable-p file)
> (with-temp-buffer
> (when (or (org-file-has-changed-p file)
> --
> 2.41.0
