Morgan Smith <morgan.j.sm...@outlook.com> writes: > * lisp/org.el (org-cached-entry-get): Rewrite in terms > `org-entry-get'. Obsolete in favor of `org-entry-get'. > (org-make-tags-matcher): Replace uses of `org-cached-entry-get' with > `org-entry-get'. > --- > Hello! > > All tests pass. > > All of the logic here already exists in `org-entry-get'. > > This function is mentioned in very few commits unlike its more popular > sibling.
This function should yield speedups when matching special properties like "CLOCKSUM", "CLOCKSUM_T", "TIMESTAMP", or "TIMESTAMP_IA". For example, when the requested match tests these properties multiple times. > I don't think we can justify the existence of this function but let me know if > I'm wrong. > > The caching mechanism used here is likely to cause hard to diagnose issues. If you encountered such issue, please let me know. Otherwise, I do not see any reason to remove `org-cached-entry-get'. We need a real-life justification, not a theoretical one. Canceled. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
