[சனி ஜூன் 15, 2024] Ihor Radchenko wrote: > Visuwesh <visuwe...@gmail.com> writes: > >>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) >>> table num-cols params) >> >> Done in the attached patch. > > Thanks! > >> ;; Dump table to datafile >> - (let ((dump-func (plist-get type :data-dump))) >> + (let* ((dump-func (plist-get type :data-dump))) > > Why let*?
Oops, leftover change from a previous iteration of the patch. Now fixed. >> + (setq data-file (org-babel-temp-stable-file >> + (list (or dump-func 'org-plot/gnuplot-to-data) >> + table num-cols params) >> + "org-plot")) > > Please add in-code comment explaining why we need > `org-babel-temp-stable-file'. Now done.
>From a922946b3965e117dc3bbbe5a4f3c67dcc832d68 Mon Sep 17 00:00:00 2001 From: Visuwesh <visuwe...@gmail.com> Date: Sat, 15 Jun 2024 10:25:19 +0530 Subject: [PATCH] org-plot: Make data-file stable for replot-on-resize * lisp/org-plot.el (org-plot/gnuplot): Use a stable data-file to make replot-on-resize in GUI terminals work. Reported-by: Visuwesh <visuwe...@gmail.com> Link: https://orgmode.org/list/87mso7sl6g....@gmail.com --- lisp/org-plot.el | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lisp/org-plot.el b/lisp/org-plot.el index 283d993..83483b2 100644 --- a/lisp/org-plot.el +++ b/lisp/org-plot.el @@ -662,8 +662,7 @@ (defun org-plot/gnuplot (&optional params) (looking-at "[[:space:]]*#\\+")) (setf params (org-plot/collect-options params)))) ;; collect table and table information - (let* ((data-file (make-temp-file "org-plot")) - (table (let ((tbl (save-excursion + (let* ((table (let ((tbl (save-excursion (org-plot/goto-nearest-table) (org-table-to-lisp)))) (when (pcase (plist-get params :transpose) @@ -681,12 +680,11 @@ (defun org-plot/gnuplot (&optional params) (nth 0 table)))) (type (assoc (plist-get params :plot-type) org-plot/preset-plot-types)) - gnuplot-script) + gnuplot-script data-file) (unless type (user-error "Org-plot type `%s' is undefined" (plist-get params :plot-type))) - (run-with-idle-timer 0.1 nil #'delete-file data-file) (when (eq (cadr table) 'hline) (setf params (plist-put params :labels (car table))) ; headers to labels @@ -697,6 +695,12 @@ (defun org-plot/gnuplot (&optional params) (setf params (org-plot/collect-options params)))) ;; Dump table to datafile (let ((dump-func (plist-get type :data-dump))) + ;; Use a stable temporary file to ensure that 'replot' upon + ;; resizing a GUI gnuplot terminal window works. + (setq data-file (org-babel-temp-stable-file + (list (or dump-func 'org-plot/gnuplot-to-data) + table num-cols params) + "org-plot")) (if dump-func (funcall dump-func table data-file num-cols params) (org-plot/gnuplot-to-data table data-file params))) -- 2.43.0
