Phil Estival <p...@7d.nz> writes: > From Org 9.7.16, > this patch modifies ob-sql to add support for session. > - reintroduces sqlite in ob-sql (even if there is ob-sqlite.el) > - limitation: no line number in session (a block is provided > on one prompt line) > - tests: some generic macro for checking results could go up/out > of this test set.
Thanks a lot for the patch and for adding yourself as a maintainer! Before I start a more detailed preview, may you please: 1. Rebase your changes onto main (development) branch. This is where the new features are added. See https://orgmode.org/worg/org-maintenance.html#branches 2. Get rid of whitespace-only commits. See https://orgmode.org/worg/org-contribute.html#orge765e69 3. If possible, add a commit message to each patch in the series. It will make things easier for me during the review, as I will have an idea about the general purpose of each patch in the series. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
