Michael Brand <michael.ch.br...@gmail.com> writes: > For this specific subject I can not see a follow up in this thread, or > an implementation on the branches bugfix or main. And the complaint of > the OP about the failing test is still valid on bugfix (on main ~make > test~ aborted before with "void-variable (file)" on "(delete-file > file)" quite early when loading testing/lisp/test-ob-tangle.el).
There was a transient problem on main. Now, make test should run. This thread concluded with https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=413192698 (on main) > As far as I understand and agree, some Org functionality wants to > stick with ~string-collate-lessp~. Is it welcome if I finish working > on my local patch that plans to use > > #+begin_src emacs-lisp > (defun org-test-string-collate-lessp-ignore-case-supported-p > (&optional locale) > "Whether `string-collate-lessp' supports ignore case for LOCALE. > According to the docstring of `string-collate-lessp' it does not > implement ignore case for some locale on some operating > systems (actually depending on libc of Emacs). E. g. on macOS > `string-collate-lessp' does not ignore case for the locale C. > > See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59275 and > https://list.orgmode.org/orgmode/m2ilkwso8r....@me.com"; > (let ((ignore-case t)) > (string-collate-lessp "a" "B" locale ignore-case))) > #+end_src > > not to skip the test as suggested in the quote at the beginning of > this message but to bifurcate the expected result of the ERT to fix > the test for e. g. macOS on bugfix? AFAIU, this is more complex. We cannot have a simple test for all possible locales. Or did you find one? My conclusion from bug#59275 discussion is that simple tries like (string-collate-lessp "a" "B" locale t) will not work. Especially for non-US locales. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
