Stefan Kangas <stefankan...@gmail.com> writes:

>> I am attaching tentative patch to make use of completion-at-point.
>> Let me know if you see something obviously wrong.
>
> Thanks for looking into this.
>
> I can't see any problems with your patch, myself.  Could we install it
> on master in emacs.git separately, so that we can delete this obsolete
> function too?

Yes, I think.

Applied, onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=50b33e2d55

>> -    ["Complete Lisp Symbol" lisp-complete-symbol t]
>> +    ["Complete Lisp Symbol" completion-at-point t]
>
> (The final `t' there is redundant and can be left out.)

What you are saying is against the docstring. It does not say that
ENABLE is optional:

    easy-menu-define is a macro defined in easymenu.el.
    ...
    The rest of the elements in MENU are menu items.
    A menu item can be a vector of three elements:
    
      [NAME CALLBACK ENABLE]

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to