Jules Tamagnan <jtamag...@gmail.com> writes: > I hope this email finds you well. This is my first time contributing to > this mailing list attempting to contribute to org-mode, so hopefully I > do this correctly.
Welcome! You do not have to do everything correctly beforehand and alone. We will tell you if something needs to be added or changed. > I recently noticed that `org-string-width` ran all buffer hooks like > `buffer-list-update-hook` for the ` *Org string width*` buffer. This > doesn't seem needed because it feels like ` *Org string width*` should > act like a temporary buffer that is only needed for these simple > operations. With that in mind I wanted to set `inhibit-buffer-hooks` to > `t`. > > Hopefully this rationale and patch makes sense. After getting this in I > can also review other places that `get-buffer-create` is used and > possible use `inhibit-buffer-tools` there as well if it would help. Yes, it does. > - (with-current-buffer (get-buffer-create " *Org string width*") > + (with-current-buffer (get-buffer-create " *Org string width*" t) ... just one problem - `get-buffer-create' in Emacs 27 does not yet have the second optional argument. And we still support Emacs 27 (until when Emacs 30 is released). See https://orgmode.org/worg/org-maintenance.html#emacs-compatibility Also, since we are using `get-buffer-create', we only do it once per Emacs session at most. So, I am not sure if it is a big deal. I do not mind merging the patch after Emacs 30 is out though. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
