Kévin Le Gouguec <kevin.legoug...@gmail.com> writes:
> One question: should it be "before saving" or "before exiting"? [...]
I gave this some more thought, and you are right. From the user's POV,
the question is *not* about saving but about clocking out. Saving is
implied. I updated the message, and the commit message too.
Ihor, if you are OK with this version, please merge. :)
Rudy
>From 10c80436b6ad02b7684394f25e7d60e529d95bd4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rud...@adamkovic.org>
Date: Mon, 24 Feb 2025 13:19:46 +0100
Subject: [PATCH] org-clock: Improve the clock-out message
* lisp/org-clock.el (org-clock-kill-emacs-query): Reword "Clock out
and save?" to "Clock out before exiting?", as the "save?" part is
confusing: the user might think their file will not be saved, as in
"data loss", if they answer no.
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 933c05487..d72ef4e29 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -3316,7 +3316,7 @@ The details of what will be saved are regulated by the variable
"Query user when killing Emacs.
This function is added to `kill-emacs-query-functions'."
(let ((buf (org-clocking-buffer)))
- (when (and buf (yes-or-no-p "Clock out and save? "))
+ (when (and buf (yes-or-no-p "Clock out before exiting? "))
(with-current-buffer buf
(org-clock-out)
(save-buffer))))
--
2.39.5 (Apple Git-154)
--
"All you have to do is write one true sentence. Write the truest
sentence that you know." --- Ernest Miller Hemingway (1899-1961)
Rudolf Adamkovič <rud...@adamkovic.org> [he/him]
http://adamkovic.org
