Ihor Radchenko <yanta...@posteo.net> writes:
> Thanks, but I have some concerns.
Of course you do. :)
> This won't work. js-comint.el hard-coded buffer name to be
> "*Javascript REPL*". We cannot change that.
Fixed. I replaced the change with a comment to inform the reader that
JS is miscapitalized on purpose, so that this will not happen again.
>> - pre.src-js:before { content: 'Javascript'; }
>> + pre.src-js:before { content: 'JavaScript'; }
> Is there any chance that this will break user CSS?
AFAIK, no. CSS3 has only empty/non-empty content selector.
>From b1cc7d9085ab4fc47a7b8196a873d1e5a755d567 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rud...@adamkovic.org>
Date: Fri, 21 Mar 2025 14:25:05 +0100
Subject: [PATCH] Capitalize JavaScript correctly
* doc/org-manual.org (Exporting to minimal HTML):
* etc/ORG-NEWS (Add ~:session~ support of ob-js for js-comint):
* lisp/ob-js.el (org-babel-js-function-wrapper):
(org-babel-execute:js):
(org-babel-variable-assignments:js):
(org-babel-js-initiate-session):
* lisp/ox-html.el (org-html-style-default):
(org-html-klipse-selection-script):
Re-capitalize "Javascript" to JavaScript.
---
doc/org-manual.org | 2 +-
etc/ORG-NEWS | 2 +-
lisp/ob-js.el | 9 +++++----
lisp/ox-html.el | 4 ++--
4 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/doc/org-manual.org b/doc/org-manual.org
index 1f4fe5a6f..7561c0d62 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -13554,7 +13554,7 @@ name, and date.
*** Exporting to minimal HTML
:PROPERTIES:
-:DESCRIPTION: Exporting HTML without CSS, Javascript, etc.
+:DESCRIPTION: Exporting HTML without CSS, JavaScript, etc.
:ALT_TITLE: Bare HTML
:END:
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 332586f4f..46a67eaab 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -4763,7 +4763,7 @@ wget -c "https://ben.akrin.com/crackzor/crackzor_1.0.c.gz";
#+end_example
*** Add ~:session~ support of ob-js for js-comint
-#+begin_src js :session "*Javascript REPL*"
+#+begin_src js :session "*JavaScript REPL*"
console.log("stardiviner")
#+end_src
diff --git a/lisp/ob-js.el b/lisp/ob-js.el
index 309f04929..816aa972e 100644
--- a/lisp/ob-js.el
+++ b/lisp/ob-js.el
@@ -1,4 +1,4 @@
-;;; ob-js.el --- Babel Functions for Javascript -*- lexical-binding: t; -*-
+;;; ob-js.el --- Babel Functions for JavaScript -*- lexical-binding: t; -*-
;; Copyright (C) 2010-2025 Free Software Foundation, Inc.
@@ -73,10 +73,10 @@
;; parenthesis are not shadowed if the last line of the body is a
;; line comment.
"require('process').stdout.write(require('util').inspect(function(){%s\n}()));"
- "Javascript code to print value of body.")
+ "JavaScript code to print value of body.")
(defun org-babel-execute:js (body params)
- "Execute Javascript BODY according to PARAMS.
+ "Execute JavaScript BODY according to PARAMS.
This function is called by `org-babel-execute-src-block'."
(let* ((org-babel-js-cmd (or (cdr (assq :cmd params)) org-babel-js-cmd))
(session (cdr (assq :session params)))
@@ -158,7 +158,7 @@ specifying a variable of the same value."
session))
(defun org-babel-variable-assignments:js (params)
- "Return list of Javascript statements assigning the block's variables.
+ "Return list of JavaScript statements assigning the block's variables.
The variables are defined in PARAMS."
(mapcar
(lambda (pair) (format "var %s=%s;"
@@ -183,6 +183,7 @@ Return the initialized session."
(run-skewer)
(skewer-repl)
session-buffer)))
+ ;; SIC, JavaScript miscapitalized in `js-comint.el'.
((string= "*Javascript REPL*" session)
(org-require-package 'js-comint)
(let ((session-buffer "*Javascript REPL*"))
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 321f263cd..2f4ec12e2 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -332,7 +332,7 @@ This affects IDs that are determined from the ID property.")
pre.src-haskell:before { content: 'Haskell'; }
pre.src-hledger:before { content: 'hledger'; }
pre.src-java:before { content: 'Java'; }
- pre.src-js:before { content: 'Javascript'; }
+ pre.src-js:before { content: 'JavaScript'; }
pre.src-latex:before { content: 'LaTeX'; }
pre.src-ledger:before { content: 'Ledger'; }
pre.src-lisp:before { content: 'Lisp'; }
@@ -1651,7 +1651,7 @@ https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag";
selector_eval_scheme: '.src-scheme',
selector: '.src-clojure',
selector_eval_ruby: '.src-ruby'};"
- "Javascript snippet to activate klipse."
+ "JavaScript snippet to activate klipse."
:group 'org-export-html
:package-version '(Org . "9.1")
:type 'string)
--
2.39.5 (Apple Git-154)
Rudy
--
"I have only made this letter longer because I have not had the time to
make it shorter." --- Blaise Pascal, The Provincial Letters, 1657
Rudolf Adamkovič <rud...@adamkovic.org> [he/him]
http://adamkovic.org
