Pedro Andres Aranda Gutierrez <[email protected]> writes:
> Attached is a new version of the patch. It builds on Ihors refactoring
> patch.
> Best. /PA
Thanks!
I toyed around with the patch and I feel that we might be breaking an
important use case without recovery.
Consider something like
#+attr_latex: :centering t :width 30px
Inlined [[file:~/PersonalDocuments/avatar.png]] image.
Before the patch, avatar.png would be inlined with small width - a
useful hack.
With the patch, it will be impossible to control image width at all
(until some time in future when we introduce per-link export
attributes).
So, it looks like ignoring :width and :height attributes might not be
the best idea for the existing users. We should only drop wrapping
inline images into \begin{...} ... \end{...} blocks.
(Yeah, I know that I suggested the opposite in the earlier discussion in
https://list.orgmode.org/orgmode/87y0xc3jty.fsf@localhost/)
> - (cond ((not (org-string-nw-p options)) "")
> + (cond ((not (ox-latex-standalone-image-p link info)) "")
> + ((not (org-string-nw-p options)) "")
This part should probably be left as is and the tests adjusted accordingly.
WDYT?
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
