Tom Gillespie <tgb...@gmail.com> writes: > I've tracked the issue down, but not sure about > the best way to fix it. I've attached a patch but > worry that it might have unintended side effects.
The patch is correct I think. For side effects, you may introduce an optional argument EVAL instead of mandatory API change. That will make it 100% safe even if some third-party code is using this internal function. Also, the commit message can be improved: 1. Changes in `org-babel-lob-get-info' should be recorded 2. The fix is not just for :file, but for any header argument defined in called src block headers 3. Change in the function signature should be clearly indicated in the changelog. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>