Thomas Ingram <tho...@taingram.org> writes: > Thanks, I've reformatted my patch to follow that format. I have also > reached out to the FSF regarding copyright assignment. Please let me > know if any other corrections are needed.
Note that you do not have to do the copyright assignment for a small patch like this one. But it will be necessary if you plan to contribute more. >> May you also take a look at other calls to >> `org-publish-cache-get-file-property'? May they also benefit from >> passing project-name argument? > > I've looked at all other uses of `org-publish-cache-get-file-property' > and `org-publish-cache-set-file-property'. I don't think there is > anywhere else to make this correction. Most of the other calls are > internal org-publish functions that are less likely to have this issue. What about the call to `org-publish-cache-get-file-property' in `org-publish-index-generate-theindex'? > I considered adding PROJECT to the `org-publish-cache-set-file-property' > call in `org-publish-find-title.'/`org-publish-find-date'. However, > since `org-publish-cache-get-file-property' is always called first that > should initialized the cache. Such implicit assumptions are something to avoid, especially when we are trying to be explicit about the project being queried with your patch. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
