Ihor Radchenko writes: > Kyle Meyer <k...@kyleam.com> writes: [...] >> [*] ... at the very least, the changes from Org's 2d9e70b80 >> (org-edit-src-*: When writing back, do not displace point in undo >> list, 2024-07-09) should be considered. Plus, for compatibility, I >> think we'd want to keep org-replace-buffer-contents around but mark >> it as obsolete. > > Stefan's commit removes code repetition. As for 2d9e70b80, it does not > look like Stefan's commit changes anything compared to the existing > behavior where we do (goto-char (point-max)). Stefan even added an > assertion, making sure that point is at the right place. So, we should > be safe I think.
Okay, thanks for taking a closer look. > What about the following plan: > > 1. Revert d2e1c6789 on bugfix > 2. Apply my patch on bugfix > 3. Revert 452584d9db53 on main > 4. Merge bugfix into main > 5. Adapt Stefan's commit and apply it on main only (to be extra safe) > 6. Re-apply a different version of 452584d9db53 > obsoleting org-replace-buffer-contents by org-replace-region-contents > *only on main* Looks reasonable to me. Thank you.
