Ihor Radchenko <yanta...@posteo.net> writes:
> dmg <d...@turingmachine.org> writes:
>
>> while working with org-roam I detected the following bug:
>>
>> Create an org file with the following info:
>>
>> * heading
>>
>> * heading 2
>> ...
>> You will note that the location of the first heading is off (it is
>> reported as starting after the space after the asterisks)
>
> org-map-region gives no promises about the point location.
> So, technically, there is no bug.
> That said, the docstring is rather ambiguous. It should at least tell
> that the function will be called with point at heading line.
>
[...]
>
> I think that the proposed change will make sense.
> However, we also need to (1) modify the docstring to document the
> behavior. (2) Announce in etc/ORG-NEWS.
>
> Could you please update the patch accordingly?
Yes, I will send it (after, hopefully, I can run the tests--see below).
>
>> I tried to run the tests, but they failed in the python async section.
>> I was only able to run and pass 301/1260
>
> Could you please provide the details of the failure?
>
it seems to be related to python (I am running MacOS):
passed 356/1318 test-ob-plantuml/prologue (0.000778 sec)
passed 357/1318 test-ob-plantuml/single-var (0.001001 sec)
Can’t guess python-indent-offset, using defaults: 4
Python does not use GNU readline; no completion in multi-line commands.
Can’t guess python-indent-offset, using defaults: 4
passed 358/1318 test-ob-python/assign-underscore (0.064578 sec)
Can’t guess python-indent-offset, using defaults: 4
Sent: print
('ob_comint_async_python_start_958ce85c-48e1-483d-af42-cb807c90181d')...
Can’t guess python-indent-offset, using defaults: 4
Sent: print
('ob_comint_async_python_start_ae9f77ca-4aca-41fc-94ef-af28fa5b0250')...
error in process filter: Search failed:
"ob_comint_async_python_\\(start\\|end\\|file\\)_\\(.+\\)"
Failed to remove temporary Org-babel directory
/var/folders/_f/2r7vwdj90j12k0g51xkh80g40000gn/T//tmp-orgtest/
make: *** [test] Error 255
[] 1& [:~/git.w/org-mode] main(1)*⭚origin 1m3s 2 ±
I have python installed:
[] 1& [:~/git.w/org-mode] main(1)*⭚origin 1m3s 2 ± python --version
Python 3.13.5
[] 1& [:~/git.w/org-mode] main(1)*⭚origin ±
> The commit message will need to be adjusted as I described, highlighting
> that we are introducing a consistent behavior.
> Also, please follow the commit message format, as described in
> https://orgmode.org/worg/org-contribute.html#commit-messages
>
> If you are willing to, it would also be nice to add a couple of test for
> org-map-region (there are currently none). That's optional though.
Hopefully you have some idea why my tests are failing.
If I can address that, I'll add some tests.
thank you,
--
Daniel M. German "Language alone protects us from the scariness
of things with no names.
Toni Morrison -> Language alone is meditation. "
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .
