Max Nikulin <maniku...@gmail.com> writes: >> https://list.orgmode.org/t7aqif$c2f$1...@ciao.gmane.io/ >> [PATCH] org.el: Use `call-process' to launch external viewers (was: Re: >> [BUG] org-open-file immediately termininates when calling xdg-open that >> calls emacsclient). >> Fri, 3 Jun 2022 00:04:12 +0700 >> >> Comments should be updated. > > The question is which way switching to `call-process' may affect macOS > and Windows users. (I am in doubts if anybody opens file from Org while > using DOS.) Are there Windows users who have something besides > system/default in `org-file-apps'? Certainly error handling becomes > completely impossible. > ... > The main question is effect of the patch on macOS, other complications > may be postponed.
What about updating your patch to only use `call-process' on gnu systems and fallback to the existing code otherwise? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
