Hi! Thanks for joining the discussion! Den 10 november 2025 08.38.55 EET, Pedro Andres Aranda Gutierrez <[email protected]> skrev: >Just my .2 cents inline. > >Just a word of caution for users on master. >The new keymap functions like (keymap-set-after ...) are still bumpy. >If you want any item to appear in the menu, check that the text shown in >the menu item passes (key-valid-p). >This is currently not the case for 'Show/Hide' 'Export, etc.
Good point! I will add a test for this in the keymap building function and signal an error if key-valid-p does not pass. > >Yet another .2 cents, /PA > >On Mon, 10 Nov 2025 at 05:52, Tor-björn Claesson <[email protected]> >wrote: > >> Some errors crept along in the previous version, here is a fixed one, >> sorry for the spam. >> >> So, to recapitulate I have two questions, one small and one about the >> scope of this patch. >> >> The small one: should we drop the description field and always use the >> first line of the docstring for menu titles? This feels much smoother. >> > >That depends on how you craft either... Don't docstrings tend to grow (even >their first line)? Still, I think I would prefer using the first line as menu title and skipping the description argument. I will implement this change unless Ihor is of a different opinion. > >The big: should this be about choosing an "action" at point, or a >> more general framework for presenting menus? If it remains small in >> scope, should we find an other name than org-menu? >> > >I was a bit tired of the wealth of information shown after C-c C-e and went >for a more contained version with which-key in the minibuffer. >In my case, it helps me compress the functions I really need into a menu... > Would you mind sharing this version? I would love to add it as an option :-) Cheers Tor-björn
