On Tue, 11 Nov 2025 at 13:43, Ihor Radchenko <[email protected]> wrote:
> Pedro Andres Aranda Gutierrez <[email protected]> writes: > > >> This is a breaking change in the API function. Instead of adding a new > >> argument in the middle of the argument list, please add it as an > >> optional argument at the end. It will be the least intrusive approach. > >> > > This will be in an isolated commit. The rest is already committed. > > Thanks! > I think you forgot changing the call in ob-latex.el. Also, ORG-NEWS > needs to be updated. > Right! Fixed > > +*** Added mandatory parameter ~fspec~ to ~org-splice-latex-header~ > is no longer accurate. > Changed > > Also, a test is again failing > FAILED test-org-export/activate-smart-quotes > Don't know how this is affected by the latex exporter... I will need your help. > >> > modified lisp/ox-latex.el > >> > >> > +(declare-function org-list-or-null-p "org-macs.el" (object)) > >> > >> I think this is redundant. > > I included this after my Emacs (with nativecomp) started complaining > > and it pacified it. > > You probably missed something. Compiler cannot complain about this > function - it is a part of org-macs and org-macs is loaded by ox-latex. > Probably... removed. > > > modified .gitignore > > +testing/.test-org-id-locations > > What is this change about? > Hmmm... don't know (could it be Magit?) > > > +*** New option ~org-latex-fontspec-config~ > > +*** New option ~org-latex-fontspec-config~ > > There is a duplicate heading in ORG-NEWS. Probably slipped during one of > the merges. > Fixed > > +(ert-deftest test-ox-latex/lualatex-fontspec-plain () > > + "Test that neither defaultfontfeatures nor directlua block is not > created > > +when no fallbacks in fontspec configuration" > > + (let ((org-latex-compiler "lualatex") > > + (org-latex-multi-lang t) > > t is not a valid value for org-latex-multi-lang now. > Same in other tests. > > I also reverted some stray whitespace changes on the branch. > > With the above comments, I went through all the changes on the branch > vs. main. After you address this latest round of comments, I will go > ahead and move to things we postponed during the previous discussions. > First, to what may need to be addressed before we merge the branch > upstream. Then, we can do the merge. And, finally, we can go further and > discussion any extra ideas we may want to implement to improve the new > feature that will be on main by then. > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler "Sagen's Paradeiser" (ORF: Als Radiohören gefährlich war) => write BE! Year 1 of the New Koprocracy
