Rudolf Adamkovič <[email protected]> writes:

> I used /Title Case/ capitalization, as seen in Emacs menus, but now that
> you mention it, I think you are right.  This is not a menu.  I am
> attaching a new patch that used /Sentence case/ capitalization.

I do not see anything attached here.
However, since the change only touches capitalization, I will still
comment on the previous patch.

> -     "Select a file and attach it to the task, using `org-attach-method'.")
> +     "Attach File...")

I am not sure if I like removing the reference to `org-attach-method'.
That reference might actually be useful.

> -     "Open current node's attachment directory.  Create if missing.")
> +     "Open Attachment Directory")

I think "create if missing" is a useful clarification. Especially for
people concerned with file system "littering".

> -     "Delete one attachment, you will be prompted for a file name.")
> +     "Delete Attachment...")

I'd say that the clarification about prompt was helpful.

> +    ((?z ?\C-z) org-attach-sync
> +     "Synchronize Manual Attachment Updates\n")

I have no idea what "manual attachment updates" mean.

>      ((?s ?\C-s) org-attach-set-directory
> -     "Set a specific attachment directory for this entry. Sets DIR 
> property.")
> +     "Set Attachment Directory...")
>      ((?S ?\C-S) org-attach-unset-directory
> -     "Unset the attachment directory for this entry.  Removes DIR property.")
> -    ((?q) (lambda () (interactive) (message "Abort")) "Abort."))
> +     "Unset Attachment Directory...\n")

Note that attachment directory is not necessarily defined by DIR
property. So, the clarifications are important here. Someone may think
that it will ad//remove ID.

> +               (while (and (setq c (pcase (read-key)
> +                                        (`(,key . ,_) key)
> +                                        (key key)))
> +                              (memq c '(?\C-n
> +                                          down
> +                                          wheel-down
> +                                          double-wheel-down
> +                                          triple-wheel-down
> +                                          ?\C-p
> +                                          up
> +                                          wheel-up
> +                                          double-wheel-up
> +                                          triple-wheel-up
> +                                          ?\s
> +                                          ?\C-v
> +                                          ?\d
> +                                          ?\M-v)))

This is getting out of control.
Maybe we can use `set-transient-map'?

> -      (message "Attachment directory removed")
> +      (message "Attachment directory delete")

*deleted


-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to