OK, I can go ahead and make the changes. Two questions: 1. For the WORGG change, that needs to be a separate patch because that's a different repo. Should there be anything at all in CONTRIBUTE.org, or just leave it in the original state? 2. Previously you said to add the git hooks target to `all', but I wonder if this should be opt-in or opt-out. Instead of adding some sort of configuration (e.g. environment variable, file settings, etc), maybe I can just leave the git hooks target out of `all' . Thoughts?
Thanks, Derek On Sat, Nov 15, 2025 at 11:13 AM Ihor Radchenko <[email protected]> wrote: > Derek Chen-Becker <[email protected]> writes: > > > Patches attached for the numeric priorities as well as the removal of the > > "show" parameter and an updated `mk/targets.mk' to install and remove > the > > git hook scripts. > > Thanks! I have several comments on the hooks. > 1. The hooks still have # This file is not part of GNU Emacs > Those lines should be removed. The file headers should also be > modified to refer to Org mode. GNU Emacs -> Org mode. > 2. If you look at the rest of CONTRIBUTE.org, you will see that it > refers to WORG for basically everything. We should probably modify > WORG page and refer to it instead. (At some point, that page should > go back to the main repo, but that's a different story) > 3. You should document how to disable the hooks for people who do not > want them. > 4. You should document how to remove the installed hooks (make cleanall) > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
