Hi friends, I just finished polishing my code, splitting them into commits, as well as adding/updating a bunch of test cases! Please check the attached for the patch files.
I have run =make test= on every commit, so they should be fine. However, my last commit didn't quite pass the =ob-tangle/detangle-false-positive= test case, but when I manually go to =testing/examples/babel.el= and run =org-babel-detangle= it worked fine though. Not sure if the failure is related to my local setup or something else. Also, I believe that test is only meaningful for the old implementation, which doesn't really parse the Noweb comments, and can be fooled by regexp patterns that look like a link. This won't happen in the new implementation anyways, so I decided that this should be fine. Thanks for everyone's help, MT On Mon, Nov 24, 2025, at 13:06, Ihor Radchenko wrote: > MT <[email protected]> writes: > > > ... The consequence is that, when =:noweb-prefix no=, we lose the > > indentation for ="hello"= and =suffix=. As a consequence, Python users > > should be extremely careful when using =:noweb-prefix no= with =:comments > > noweb= (e.g., it's still fine to write: ~print(<<a string>>)~). > > Aha! I actually missed =:noweb-prefix no=. > I agree that =:noweb-prefix no= for python is a bad idea. > > Looking forward for your more granular patches/changes that address the > general bugs you mentioned (unless they cannot be easily separated from > the rest of the changes). > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> >
0001-lisp-ob-core.el-Fix-incorrect-interposition-of-Noweb.patch
Description: Binary data
0002-lisp-ob-tangle.el-Fix-incorrect-trimming-behavior-on.patch
Description: Binary data
0003-lisp-ob-core.el-Also-generate-numbered-names-for-unn.patch
Description: Binary data
0004-lisp-ob-core.el-Enrich-the-Noweb-comments-genereated.patch
Description: Binary data
0005-lisp-ob-tangle.el-Rewrite-Noweb-comment-parsing-and.patch
Description: Binary data
0006-lisp-ob-tangle.el-Rewrite-detangling.patch
Description: Binary data
