Francois Polito <[email protected]> writes:

> * org-contrib/babel/languages/ob-doc-scad.org: New file. Add OpenSCAD 
> documentation for Org Babel.
> * org-contrib/babel/languages/images/: Add example images for OpenSCAD 
> documentation.

Thanks!
I have a few comments:
1. Org-mode -> Org mode
2. You do not mention that ob-scad can be installed from ELPA. Or is it
   distributed as a part of Openscad itself?

> +** Differences from Other Supported Languages
> +*** Not Directly Supported
> +
> +- *Console output* (=echo()=, warnings, errors), use shell wrapper for 
> console capture (see [[Capturing OpenSCAD Console Output][console section]])

I am wondering why this was not implemented as a part of ob-scat itself
when there is :results output. Not relevant to accepting this patch though.

> +* OpenSCAD Title Logo
> +
> +This example demonstrates how to generate an image using an OpenSCAD code 
> block and place the resulting image anywhere in your Org document using the 
> =#+RESULTS:= directive. In this case, the logo is generated and displayed at 
> the top of the page as the title logo.
> + ...
> +    echo(version=version());

I am wondering why you put echo in the example if it is never captured.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to