Thomas Ingram <[email protected]> writes:

> Quick correction, I've added the :safe declaration recommended by Pedro.
> I was not aware of that customization feature.

Thanks!

> +(defcustom org-cite-bibtex-bibliography-style 'plain
> +  "Default BibTeX bibliography style."

It would be nice to expand about possible values in the docstring.

> +  :group 'org-cite
> +  :package-version '(Org . "9.8")
> +  :type
> +  '(choice
> +    (const plain)
> +    (const unsrt)
> +    (const alpha)
> +    (const abbrv)
> +    (symbol :tag "Other"))

You can also add :tag to other values briefly describing what they do.

> +  :safe #'stringp)

Yet, the default value is a symbol, which is confusing.

Also, please document the new customization in etc/ORG-NEWS and possibly
in the manual.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to