John Wiegley <[email protected]> writes:
> the attached code works for me and expresses
> the idea.
The diff unfortunately does not apply, so testing is tricky.
Some comments:
1. Looks like you always calculate all TBLFM lines, which is not the
default that vanilla calculator uses.
2. You are calling org-table-align unconditionally, even if no changes
are made. It *will* slow things down on long complex tables.
3. "Double definition `%s=' in TBLFM line, please fix by hand" notice is missing
4. Named fields does not seem to be supported. There is
org-table-loeb--current-env but it is not used at all.
5. "A3" reference format does not seem to be supported
6. remote references does not seem to be supported
7. + ;; Replace --matrix-- and --row-map-- with proper bindings
+ (fixed (replace-regexp-in-string
+ "--row-map--" "the-row-map"
+ (replace-regexp-in-string
+ "--matrix--" "the-matrix" substituted)))
Why??
8. No formatting support. No support for empty cell values.
I suggest running your patch through standard org-table tests.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
