On 2026-01-12 14:47, Ihor Radchenko wrote:
> Applied, onto main, with amendments to the commit message.
Thanks! That was the last suspicious ‘char-to-string’ on my radar
(besides ‘org-mouse’ and a test where it doesn’t matter; attached is
an optional patch for the latter that can be squashed into the next
fix). I think you’re working on ‘org-mouse’ Derek?
P.S. It seems like [Emacs] tolerates both `doc string style' and
'plain style' quoting, with the latter being more consistent with
examples in the ['GNU standards']. Is there a reason why the former
is [preferred in Org]?
[Emacs]
<https://cgit.git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE?id=ec3ade22fcc495cffbe054b1a407f99864ed7c80#n283>
['GNU standards']
<https://www.gnu.org/prep/standards/html_node/Change-Logs.html>
[preferred in Org]
<https://orgmode.org/worg/org-contribute.html#commit-messages>
--
Jacob S. Gordon
[email protected]
Please don’t send me HTML emails or MS Office/Apple iWork documents.
https://useplaintext.email/#etiquette
https://www.fsf.org/campaigns/opendocumen
From f347f101eb0219d8fadc3aa1e1475714c35550b5 Mon Sep 17 00:00:00 2001
From: "Jacob S. Gordon" <[email protected]>
Date: Mon, 12 Jan 2026 16:20:00 -0500
Subject: [PATCH v1] ; test-org: Use `org-priority-to-string' to convert
priorities
* testing/lisp/test-org.el (test-org/entry-properties): Use
`org-priority-to-string' instead of `char-to-string'.
---
testing/lisp/test-org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el
index 7205ab948..6015e6fd0 100644
--- a/testing/lisp/test-org.el
+++ b/testing/lisp/test-org.el
@@ -7254,7 +7254,7 @@ (ert-deftest test-org/entry-properties ()
(org-test-with-temp-text "* [#A] H"
(cdr (assoc "PRIORITY" (org-entry-properties))))))
(should
- (equal (char-to-string org-priority-default)
+ (equal (org-priority-to-string org-priority-default)
(org-test-with-temp-text "* H"
(cdr (assoc "PRIORITY" (org-entry-properties nil "PRIORITY"))))))
;; Get "FILE" property.
base-commit: c83fbea516eeed2f9b4e7f91c2b8f4abd083c118
--
Jacob S. Gordon
[email protected]
Please don’t send me HTML emails or MS Office/Apple iWork documents.
https://useplaintext.email/#etiquette
https://www.fsf.org/campaigns/opendocument
