>> + :process-variables >> + ((process-adaptive-read-buffering process-adaptive-read-buffering) >> + (process-connection-type process-connection-type) >> + (read-process-output-max read-process-output-max)) > > You added this, but process-connection-type/adaptive-read-buffering are > hard-coded to default to nil.
You're right, I believe we mean to use a pipe for process-connection-type and turn off adaptive-read-buffering by default in org-async. Setting these to nil is intentional for performance reasons, and this can be changed by providing the process-variables as an argument to org-async-call. I will change the docstring again. >> I don't think anything needs to be said about BUFFER here? The fact >> that start-process is called with BUFFER as its buffer argument is an >> implementation detail, and the meaning of BUFFER is covered further down >> in the docstring. > > I see why I was confused. I thought that "arguments" are `start-process' > arguments, not command arguments. How about: A string will be run as a shell command with `start-process-shell-command', and a list run using `start-process' with the car as the command and the cdr as the command arguments.
