Karthik Chikmagalur <[email protected]> writes: >> Should it be defcustom? In any case, the docstring is not sufficient to >> understand all the %X inside. > > I think this should be a defvar, there is no reason for users to mess > with it. > > I've improved the documentation (squashed).
Ok. >> Let's prefer (temporary-file-directory) over temporary-file-directory > > I've made a note along with the other final checks -- there are many > uses of this in org-latex-preview.el, so I'll do it at the end along > with the other replacements. It will make it hard to rebase otherwise. Ok. Pending. >>> (when-let ((dump-file >> >> when-let* > > Postponed to before-merge. Ok. Pending. >>> (default-directory >>> (if tempfile-p temporary-file-directory default-directory)) >>> ... >>> (org-latex--precompile-preamble >>> info preamble >>> (expand-file-name preamble-hash >>> temporary-file-directory) >>> spec) >> >> This looks sus. Do you really want to pass (expand-file-name >> preamble-hash temporary-file-directory) even when tempfile-p is nil? > > I think this is correct. I remember us being confused about this too > before arriving at this solution. I can research this after Tuesday. Ok. Maybe a comment can be added explaining that it is really correct and why. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
