>> + ;; :processor One of dvipng, dvisvgm or imagemagick > > What if users add a new processor to `org-latex-preview-process-alist' > and select it as default?
I reworded it to mention org-latex-preview-process-alist. >> + ;; :org-buffer Buffer from which preview is dispatched, not >> + ;; necessarily an Org mode buffer. > > I cannot help but wonder why it is called :org-buffer then. It was decided on when this function was only called to place previews in Org buffers. This is still the case, unless you call it programmatically via org-latex-preview-create-images. On balance, :org-buffer is a better name than :buffer. >> I've now replaced all instances of this calculation: >> >> (- (org-element-property :end element) >> (or (org-element-property :post-blank element) 0) >> (if (eq (char-before (org-element-property :end element)) >> ?\n) >> 1 0)) >> >> with this: >> >> (org-with-wide-buffer >> (goto-char (org-element-property :end element)) >> (skip-chars-backward "\n\r\t ") >> (point)) >> >> I couldn't find a way to do it with just org-element. If you know of a >> better way please let me know. > > There is none just yet. I will add :pos-before-blank parser property as > a part of refactoring branch. This is a common need. Okay. >>> With this, I went through all the changes, except unrelated to the latex >>> preview branch. >> >> Thanks. I think I've addressed all feedback related to >> org-latex-preview.el itself (not ox-html, ox-odt etc) except for >> >> - %O placeholder in org-latex-preview-process-alist > > This is yet to be discussed. Pending. I haven't had time to think about why it seems like this won't work. Unfortunately I've been too busy since I started at the new place. Karthik
