"Jacob S. Gordon" <[email protected]> writes:
>> If you have time to look at the org-mouse changes, that would be
>> helpful.
>
> 2. ; org-mouse: Refactor priority menus
>
> This one makes the local and global context menus consistent w.r.t.
> priorities, i.e., selecting the default when none is set and being
> able to remove them.
I have some concerns about this one.
The old code uses
`(["None" org-mouse-remove-match-and-spaces
:style radio
:selected ,(not (member (match-string group) keywords))])
while the new code refactors this to simply use "None", without style/selected.
> There’s a couple of lingering issues, and I could use your help with
> the first:
>
> + ‘org-agenda-show-priority’ is long gone, so I tried switching to
> ‘org-priority-show’. However, it and ‘org-get-priority’ both seem
> to be referring to the urgency-transformed priority instead of the
> value. Is there some other function I should be using? I found the
> names confusing.
Agree. That part is confusing.
I think using org-priority-show is the most reasonable in terms of
historic behavior.
> + This isn’t limited to priorities, but commands are unhappy when
> called from the agenda, even though they seem to work:
>
> save-current-buffer: Symbol’s value as variable is void: org-mouse-cmd
Maybe those messages can be simply removed.
I dug git history, and it looks like org-mouse-cmd was never there to
start with. org-mouse-cmd was introduced to replace _cmd, which was
removed in 79605a900 that moved `org-with-remote-undo' to use
`org-with-gensyms' that hides explicit let-binding inside macro.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
