Morgan Smith <[email protected]> writes: > Ihor Radchenko <[email protected]> writes: >> >> Ok, but then we need to make sure that we are actually using the time in >> the expected format. Your patch org-timestamp-change: Use proper time >> structure accessor functions uses decoded-time-minute on time0, which is >> from org-parse-time-string. And org-parse-time-string just returns a >> list. Note that decoded-time-minute is a struct method. That struct >> might change in subtle ways, so we should not rely on the list and >> struct being equivalent. > > These are fair points. However, I don't want to go back to the obscure > list accessor functions that where there before. I also don't want to > duplicate the decoded-time accessor functions. So what do you think of > the attached patch? All the tests still pass and there are no compile > warnings.
The patch is fine in general. But now we also need to go through all the users of `org-parse-time-string' and check whether they need to be changed. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
