Christian Barthel <[email protected]> writes:
>> Look right.
>> Maybe you can test a couple of other edge cases like anchor
>> before first heading.
>
> I’ve added a few additional test cases.
Thanks! The code change look reasonable now.
> (ert-deftest test-org-link/id-store-link ()
> "Test `org-id-store-link' specifications."
> + (let ((org-id-link-to-org-use-id t))
> + (should
> + (equal '("id:b82baea1-4203-4f97-a52d-6a0534873c92::myanchor"
> "myanchor")
> + (test-ol-stored-link-with-text "* H1\n:PROPERTIES:\n:ID:
> b82baea1-4203-4f97-a52d-6a0534873c92\n:END:\n<point><<myanchor>>\n"
> + (org-id-store-link))))
> + )
You do not have to use so long ids in the tests. Otherwise, LGTM.
> Thanks for your help and your time. Is this going somewhere near
> "commitable"?
Yup.
The next step is creating a proper patch. What you did in this email is
simply a saved magit status buffer, not a patch. See
https://docs.magit.vc/magit/Plain-Patches.html and
https://orgmode.org/worg/org-contribute.html#commit-messages
Also, you need to announce the new feature you contribute in
etc/ORG-NEWS.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
