Jack Kamm <[email protected]> writes:
> Thanks as always for the review. I attach the updated patch.
LGTM, except one comment. (see below).
>> Why only paragraphs?
>> On main, things like
>> :fixed width
>> are included into DESCRIPTION
>
> Good point. I'm not sure if there are other element types that are also worth
> including. I therefore switched to just using mapconcat over the
> top-level contents instead of org-element-map, and skipping over the
> elements that are export-blocks/keywords.
I am also not sure. But the default should be not changing how things
work unless we have a justification for such change. That's the least
risky approach.
> + (unwind-protect
> + (with-temp-buffer
> + (insert-file-contents tmp-ics)
> + (print-buffer)
I was more than surprised to see this test failing with
(user-error
"Spooling...done: /usr/bin/lpr: Error - No default destination.\n")
Luckily, I do not have a printer, or I would be even more surprised.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
