Hi Sławomir, No problem, it wasn't really a big issue. Honestly, I was surprised that git didn't handle this automatically, so that might also be something I can fix on my end. In any case, the code checked into the repo does not use LF endings, which is why I suggested setting things up to match.
Cheers, Derek On Tue, May 5, 2026 at 10:15 AM Sławomir Grochowski < [email protected]> wrote: > Derek Chen-Becker <[email protected]> writes: > > > Hi Sławomir, thanks for the patch! It did not apply for me out of the box > > because it appears to have DOS line endings. I converted and applied it > > locally and all tests pass, but you might want to check if Git is set to > > automatically append LF. > > Thank you Derek for reviewing my patch and bringing the line ending issue > to > my attention. I apologize for any confusion caused. > > To be honest, I'm not very familiar with the intricacies of line endings > and patch formats. I created the patch file using the tools and settings > I have on my system, and based on the output of the `file` command, it > appears to be using LF line endings: > > 0001-test-org-colview-Add-coverage-for-org-columns-quit-t.patch: unified > diff output, ASCII text > > From my understanding, this should be compatible with your > system. However, if there are any issues with applying the patch or if > you need me to make any changes, please let me know, and I'll do my best > to address them. > > Best, > -- > Slawomir Grochowski > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
