Hi Sławomir, Thanks for the patch! I researched the CRLF issues and found two things:
1. First, this seems to be part of the email RFC ( https://www.rfc-editor.org/rfc/rfc2822.html#section-2.1) to require CRLF for all message lines, so when attachments are sent using plain text encoding LF is converted to CRLF. Using base64 encoding should avoid any transformation. 2. More importantly, I've been using "git apply" for the patches when I should have been using "git am" (apply mailbox). If I use "git am", then it happily deals with the CRLFs and no conversion is necessary. Sorry for my ignorance here! In any case, the patch applies cleanly and all tests pass (including your new ones from the previous patch). Approved, for Ihor to look at. Cheers, Derek On Wed, May 6, 2026 at 9:54 PM Sławomir Grochowski < [email protected]> wrote: > > Actually, I believe it should be correct now. I've read that the Gmail > web interface adds CRLF line endings automatically, and I verified this > by checking a file downloaded that way. > > Best, > -- > Slawomir Grochowski > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
