> * lisp/org-colview.el (org-columns--display-here-column): New helper > that creates the per-column overlay, sets its seven properties, and > advances point by one character so the next column may be installed. > (org-columns--display-here): Replace the in-loop overlay creation > with a call to the new helper; drop the now-redundant `(let* ((ov > ...)) ...)' binding and the trailing `(forward-char)'.
I am not sure if helper function with a side effect is a good idea. It may be easy to miss side effects, especially when they are not mentioned as a part of the function name. "display" does not make it obvious that the point is moved. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
