Earl Chase <[email protected]> writes: >> (dolist (entry cache) >> (cl-loop for index from 0 >> for triplet in (cdr entry) >> do (setf (nth index widths) >> (max (nth index widths) >> (string-width (nth 2 triplet)))))) > > Respectfully, I disagree. The cl-loop implementation is unreadable. I > think the implementation in the patch is great.
There is always a debate about cl-lib and cl-loop in particular. IMHO, as long as we do not go too far into the weeds of cl-loop, we are fine. Basic structure is acceptable and not too bad to learn (after quick reading of the manual entry). As long as the end code is more succinct, simple cl-loop is acceptable. We have a number of examples in Org code base already. In this particular case, we have a repeated patter of (setq foo (cdr foo)), which is covered by simple cl-loop construct. Justified. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
