Hey Morgan,
Thanks for your diligence! Attached is a patch that tries to address
the errors, but I don’t have Emacs 28 setup to test (one of these days
I’ll have to ask about your multi-Emacs CI setup).
On 2026-05-18 20:40, Morgan Smith wrote:
> org-agenda.el:10303:1: Warning: variable `_' not left unused
> org-agenda.el:10303:1: Warning: variable `_' not left unused
This seems similar to [bug#69108] fixed by ‘e680827e814’ for Emacs 30.
I’ve removed the ‘_’ bindings in case that’s it.
[bug#69108]<https://lists.gnu.org/archive/html/bug-gnu-emacs/2024-02/msg00723.html>
> In org-agenda-clock-goto:
> org-agenda.el:10312:12: Warning: sort called with 3 arguments, but accepts
> only 2
Oh interesting, I didn’t know ‘sort’ was different pre-Emacs 30
(‘ae5f2c02bd2’): ‘(sort SEQ LESSP)’. I’ve adapted to the compatible
calling convention.
--
Jacob S. Gordon
[email protected]
Please don’t send me HTML emails or MS Office/Apple iWork documents.
https://useplaintext.email/#etiquette
https://www.fsf.org/campaigns/opendocument
From 88b7cc936902eaebc3a71bc68e5755873422a527 Mon Sep 17 00:00:00 2001
From: "Jacob S. Gordon" <[email protected]>
Date: Mon, 18 May 2026 21:22:35 -0400
Subject: [PATCH v1] ; org-agenda: Fix errors in Emacs 28
* lisp/org-agenda.el (org-agenda-clock-goto): Remove '_' bindings from
'when-let*' and use old calling convention of 'sort'.
---
lisp/org-agenda.el | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index f3dec749d..62f9c0c3b 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -10313,13 +10313,14 @@ (defun org-agenda-clock-goto ()
(delete-dups
(remq nil
(mapcar (lambda (o)
- (when-let* ((_ (eq (overlay-get o 'type)
- 'org-agenda-clocking))
+ (when-let* (((eq (overlay-get o 'type)
+ 'org-agenda-clocking))
(start (overlay-start o))
- (_ (not (invisible-p start))))
+ ((not (invisible-p start))))
start))
(overlays-in (point-min) (point-max)))))
- :key (lambda (p) (count-lines p pt t))))
+ (lambda (p1 p2) (< (count-lines p1 pt t)
+ (count-lines p2 pt t)))))
(closest (car visible-clock-positions)))
(cond (closest
(goto-char closest)
base-commit: 5f8fe990ee539b12d2af4d433ba3f8137c64b671
--
Jacob S. Gordon
[email protected]
Please don’t send me HTML emails or MS Office/Apple iWork documents.
https://useplaintext.email/#etiquette
https://www.fsf.org/campaigns/opendocument
