Bastien Guerry <[email protected]> writes:
> I'm not saying it's completely useless, I see your point, but the
> usefulness-to-maintenance ratio seems too low to me. So I agree with the
> approach from testing/README: "The tests are usually designed aiming to
> ensure the *expected* Org mode behavior."
The full paragraph I added says
The test suite is designed to ensure stability of Org mode code base
as it evolves, being modified by numerous contributors. The tests are
usually designed aiming to ensure the *expected* Org mode behavior.
Thus, we should not add the tests that just mechanically check what
the current implementation does. In particular, we should avoid (or,
at least, explicitly mark) the tests that simply check for some
arbitrary behavior related to the details of the implementation; not
to the original design goals. The only exception is when users get
used to certain ways the code behaves by muscle memory.
So, if Slawomir insists, it is ok to put the tests like in the commit.
But they should be marked.
There is a fixme in the code that explicitly states that the current
behavior is arbitrary, but no such comment is present in the tests.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
