Ignacio Casso <[email protected]> writes: >> Also, there is similar inconsistency with active region. I expect bugs there. > > What do you mean? Anyway, my new fix doesn't change the behavior with > active regions. If the function is called interactively, nothing > changes, and if it's call not interactively and the active region is > hidden, the command was already failing with a "org-sort-entries: Region > to sort contains a level above the first entry" error. > > That is probably a bug on its own,
That's exactly what I meant - there are more bugs in this command. Not just the one you reported. And yes, they are not directly related to your fix. Just adjacent. Your fix is already an improvement. > ... but it's not the only one I've seen > with active regions when trying to understand your comment. For example, > this file with this active region > > ``` > ;; Beginning of region > *B > ** 1 > ** 2 > > > *A > ** X > ;; End of region > ** Y > ``` > > is sorted to > ``` > * A > ** X > ;; > * B > ** 1 > ** 2 > ** Y > ``` > > I would leave active regions out of the scope of this fix. Fair enough. This is indeed a bug of its own that should also be fixed. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
