Slawomir Grochowski <[email protected]> writes: > A small follow-up: I added a characterization test for the current > behavior; commit 8a13d1fef. > > The test uses a regular level-30 headline and confirms that column > summary computation currently signals `args-out-of-range'. Therefore, > the practical effect is not merely that deeper headings fall outside > the accumulator; they can cause `org-columns' to fail. > > This also makes the situation closely analogous to `org-clock-sum', > where commit 9059c8fae removed the fixed hierarchy-depth limit by > growing the per-level accumulator as needed. > > After removing `deepest-level', the test can be changed to expect the > level-30 value to be summarized normally instead of expecting an error.
If you want to signal that we are looking for behavior change, please explicitly add a comment explaining this to the test. Or use the final goal behavior and put expected result failed. Currently, the test reads as if args-out-of-range is what we intend to do on purpose. I believe that we discussed these kinds of tests earlier. I do not oppose them, but please clearly mark the tests that merely document the state of the code vs. the actual expected design. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
