Simon Cossar <[email protected]> writes:
>>> + (let ((org-babel-clojure-backend 'clojure-cli))
>>
>> Same problem here. Why not using the default backend (if any)?
>
> That makes sense. Since both tests depend on the Clojure executable,
> maybe it's safe enough to just allow the user-error that's called in
> org-babel-execute:clojure and org-babel-expand-body:clojure to handle
> the case of no executable being configured. That simplifies the
> ob-clojure/org-babel-execute test to:
>
> (ert-deftest ob-clojure/org-babel-execute ()
> "org-babel-execute:clojure correctly handles :result-params."
> (should (equal 3
> (org-babel-execute:clojure
> "(+ 1 2)"
> '((:result-params "value")))))
> (should (equal ""
> (org-babel-execute:clojure
> "(+ 1 2)"
> '((:result-params "output"))))))
Thanks!
Just three more observations:
1. We can add something like
(unless org-babel-clojure-backend
(signal 'missing-test-dependency '("Support for Clojure code blocks")))
to skip the tests when clojure is not available
2. I have clojure-cli variant installed locally and the tests
do not pass there. Although, it is orthogonal to the patch - look
like clojure-cli logic is simply not up to date (there is no -M
command line option in current clojure version)
3. If you can, please create full patches including the commit message,
as described in https://orgmode.org/worg/org-contribute.html#commit-messages
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
