Pedro Andres Aranda Gutierrez <[email protected]> writes:
> The patch does the following
> 1.) create the THEME info by putting BEAMER_THEME_PRE before BEAMER_THEME
> 2.) insert the resulting THEME information directly after the document
> class, when this class is beamer.
Ok. Let's focus on this part then.
> + (subtitle (org-export-data (plist-get info :subtitle) info))
> + (latex-class (plist-get info :latex-class)))
latex-class is not used anywhere. (Is it the missing binding in your
other patch?)
> - (format "\\begin{frame}%s{%s}\n"
> ...
> + (format "\\begin{frame}%s\nframetitle{%s}\n"
This looks like a stray change.
You also removed one comment about TOC in the code.
> +(ert-deftest test-ox-beamer/org-beamer-test-fonts ()
> + "Test that fonts are defined correctly."
> + (let ((org-latex-compiler "lualatex")
> + (org-latex-default-packages-alist nil)
> + (org-latex-packages-alist nil)
> + (org-latex-hyperref-template nil)
> + (org-latex-fontspec-config '(("main" :font "FreeSerif") ("mono"
> :font "FreeSans"))))
> ...
> +(ert-deftest test-ox-beamer/org-beamer-ltx-talk ()
> + "Test that we can handle ltx-talk."
> ...
> +(ert-deftest test-ox-beamer/fail-ltx-talk-class ()
> + "Test that it bails out if compiler is not lualates for `ltx-talk'"
> ...
> +(ert-deftest test-ox-beamer/org-beamer-ltx-talk-listing ()
> + "Test that we can handle verbatim in frames.
> ...
> +(ert-deftest test-ox-beamer/use-ltx-talk-class ()
> + "Test that `ltx-talk' is correctly handled is defined and used."
Please remove tests that are not related to this particular patch.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
