"Pedro A. Aranda" <[email protected]> writes:

> I just base my argument in the fact that I have not found any key for 
> any of the options for either beamer or ltx-talk that would need quoting.

You are right, but, for example, I did not anticipate at all that we
will even need something non-beamer to be added to ox-beamer.
So, I prefer to avoid relying on such "obvious" assumptions, and instead
have safe code style.

Also, it is not uncommon when people look at the existing code and
either copy-paste it (I'm sure you did you yourself several times in
patches) or learn from those examples and produce similar code styles
elsewhere. Even if not quoting a variable in regexp is nearly-100% safe
in this particular scenario, I'd prefer to avoid introducing unsafe
practices.

Finally, I am genuinely surprised about your reaction to this particular
detail. I can see how the code can be somewhat less readable (more
nesting), but isn't it marginal? In my eyes, consistent safe code style
is far more important, especially when weighted against one extra set of
parenthesis.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to