Kyle Meyer <[email protected]> writes: > James N. V. Cash writes: > >> Kyle Meyer <[email protected]> writes: >> >>> Does your cider test case above break if we use >>> eldoc-print-current-symbol-info without relaying the callback? That is, >>> this squashed into your patch: >> >> My concern with using the eldoc-print-current-symbol-info is that it's >> now somewhat subverting the actual eldoc documentation function -- i.e. >> the invocation of org-eldoc-documentation-function now "fails" and >> instead it prints out the actual documentation as a side-effect. Indeed, >> applying that patch makes the eldoc for python code blocks not work >> correctly. > > Okay. Testing with the current Emacs master branch, I saw what I > thought were the expected messages, but perhaps I wasn't testing > complicated enough python blocks on my end: > > #+begin_src python > print("ok") > int(1) > #+end_src > > Either way ... > >> The below patch which essentially just inlines the definition of >> eldoc-documentation-default, so it's not messing around with any private >> variables in eldoc, although it now won't honour the documentation >> strategy. It remains to be seen if that will be an issue in practice, >> but if necessary we could just check the value of >> eldoc-documentation-strategy and behave appropriately. > > ... this sounds fine to me. Lightly testing your latest patch with > Emacs 27 and 28, things work on my end. > > Pushed (c20cb0993). Thanks.
Applied, as commit c20cb0993 This message is being sent to update our issue tracker at https://tracker.orgmode.org
