Morgan Smith <[email protected]> writes: > I viewed our relationship as one of collaborators that could freely > share ideas and code with each other. I'm still not sure what I did > wrong. I would love to know what you're thinking.
FYI, I sometimes also suggest improvements to patches in a form of code, but I usually do it either via 1. additional diff on top of the patch (small!) 2. small code examples inline in the email itself I also often do small final edits in the patch before applying, when I feel like the changes are small enough that another round of email responses is not justified or when there is an almost-ready patch without response. By putting the full updated patch, you implicitly assume that the person submitting the patch can easily identify your extra changes. That's not always trivial for people not accustomed to git/magit. > In response to me sending code you have said: > > "I feel like that defeats the purpose of the whole endeavour." > > and > > "I'm not a reviewer so I don't see what the point of reviewing your code > would be." > > I'm not sure what you mean by either of those statements. Is the > endeavour not to improve org-habit? org-habit has not been seriously > modified for a decade. If there is anyone I would want to review > org-habit code at this point in time it would be you who has put in the > work to understand it. We should not assume other's intentions. Different people have very different motivations. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
