Ihor Radchenko <[email protected]> writes: > "J.D. Smith" <[email protected]> writes: > > I had another review pass on the code.
Thanks. > More comments: > > 1. There are warnings when compiling with Emacs 29 > > In toplevel form: > org-inside.el:190:16: Warning: variable ‘_’ not left unused > org-inside.el:433:17: Warning: variable ‘_’ not left unused These are when/if-let* predicate bindings, for which the (_ (pred-p)) form is now dictated. So I think we have to ignore these warnings (unless you know of a trick) as due to an old byte-compiler bug: | If only the test result is of interest, use ‘_’ as SYMBOL, i.e. (_ | VALUEFORM), in which case VALUEFORM is evaluated and checked for nil | but the result is not bound. If it bothers you we could bind a dummy var-name, but this will be a very common situation (v29 bug vs. v31 new requirement). > In end of data: > org-inside.el:201:8: Warning: the function ‘set-window-cursor-type’ is not > known to be defined. > org-inside.el:200:50: Warning: the function ‘window-cursor-type’ is not known > to be defined. There were introduced in v30. Buffer-local cursor type doesn't work well here, because the same buffer displayed in two windows can have different "inside" status. I've added an 'fboundp guard and a note to the custom docstring. > 2. I think it is a good idea to reset font-lock when disabling > org-inside. That will clear rear-nonsticky setup. Done. > 3. org--extra-unfontify-properties value is declared to be prop t, but > it is not how org-inside uses it. See the proposed fix below: > > org-unfontify-region: Fix argument value for `remove-text-properties' Good catch, patch applied.
