"Pedro A. Aranda" <[email protected]> writes: >>> 1.- I included the :languages -> :language in the INFO channel from >>> feature/all-tex-fonts. >> >> I have removed this change from the applied patch. >> The :languages property in the patch is unused by the actual code, so >> the news entry is not very useful - you changed nothing for the users. >> I think we discussed similar situations in the past - adding new code >> APIs that are not used in the code (at least, partially) in anticipation >> of new features is not a good practice. > > Once again, I just wanted to draw _your_ attention to this and test > suggest you test it and spend some meditation time on this. > > My concern right now is that :languages provides a completely different > response to #+LANGUAGE: than the current implementation. > > If you look at the tests, there are some that expect to know only about > the last language defined with #+LANGUAGE: (for example in the HTML tests). > > I have trouble understanding what the effect of :languages may be in the > PDF when exporting such documents and wanted _your_ opinion.
You are right. One of the tests does something like doc1.org: #+LANGUAGE: en ... doc2.org: #+INCLUDE: doc1.org #+LANGUAGE: fr Allowing languages to be a list will break the above, because the language will become "en" (first value), not "fr" (last value). One way to resolve the regression will be keeping the language list in :languages but assigning the *last* language from the list as :language. However, it might be counter-intuitive. We can instead introduce a new keyword like #+LANGUAGES_EXTRA: ... that will hold a list of secondary languages. WDYT? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
